Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tqdm's process_map #4093

Merged
merged 3 commits into from
Dec 10, 2022
Merged

Add support for tqdm's process_map #4093

merged 3 commits into from
Dec 10, 2022

Conversation

peterfpeterson
Copy link
Contributor

@peterfpeterson peterfpeterson commented Nov 8, 2022

There are a few missing functions on the Tqdm object that are needed then it works. This is associated with making process_map functional.

There are a few missing functions on the Tqdm object that are needed
then it works
@KedoKudo
Copy link
Contributor

KedoKudo commented Nov 8, 2022

@MarcSkovMadsen Could you take a look at this PR? It is a feature expansion for the existing tqdm widget. 🙏

panel/widgets/indicators.py Outdated Show resolved Hide resolved
panel/tests/widgets/test_tqdm.py Show resolved Hide resolved
panel/widgets/indicators.py Show resolved Hide resolved
@peterfpeterson
Copy link
Contributor Author

Here is a demo ipynb (rename the file)

progress_bar_demo.ipynb.txt

@peterfpeterson
Copy link
Contributor Author

The last commit should resolve the reviewer comments.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the requested changes. Looks good to merge now.

@philippjfr philippjfr merged commit 3558e13 into holoviz:master Dec 10, 2022
@peterfpeterson peterfpeterson deleted the tqdm_process_map branch December 12, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants