Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator: use the index name when available #4016

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 17, 2022

Previously it wasn't possible to edit a cell in a client-side filtered column when the DataFrame index name was not 'index'.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #4016 (b1cc365) into master (608b765) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master    #4016   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files         223      223           
  Lines       33129    33132    +3     
=======================================
+ Hits        27714    27717    +3     
  Misses       5415     5415           
Flag Coverage Δ
ui-tests 37.57% <83.33%> (-0.01%) ⬇️
unitexamples-tests 74.68% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/tables.py 87.85% <0.00%> (ø)
panel/tests/ui/widgets/test_tabulator.py 98.96% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 081d13b into master Oct 17, 2022
@philippjfr philippjfr deleted the fix_edited_column branch October 17, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants