Tabulator: fix the edit event with a python filter #3829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that occurred while the edit event was being processed, when a Python filter was active. This bug led to the old value not being able to be set, as the
_old
data was then filtered but on the client the table is still the filtered one (i.e. it is not live filtered on edit, which is consistent with how Tabulator JS works and is the most practical approach).This PR also returns early in
_process_event
when no edit/click callback is registered.