Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support admin dashboard in multi-process deployments #3812

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3811

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #3812 (df306a7) into master (a4ff6ed) will increase coverage by 0.00%.
The diff coverage is 25.71%.

@@           Coverage Diff           @@
##           master    #3812   +/-   ##
=======================================
  Coverage   82.97%   82.98%           
=======================================
  Files         221      221           
  Lines       32230    32242   +12     
=======================================
+ Hits        26744    26755   +11     
- Misses       5486     5487    +1     
Flag Coverage Δ
ui-tests 34.15% <17.14%> (+0.01%) ⬆️
unitexamples-tests 75.46% <25.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/admin.py 0.00% <0.00%> (ø)
panel/command/serve.py 35.34% <33.33%> (+0.15%) ⬆️
panel/io/server.py 74.95% <70.00%> (-0.10%) ⬇️
panel/io/state.py 70.93% <100.00%> (+0.05%) ⬆️
panel/util.py 87.54% <0.00%> (+0.37%) ⬆️
panel/tests/util.py 87.12% <0.00%> (+1.98%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit d20420f into master Sep 8, 2022
@philippjfr philippjfr deleted the admin_multi_process branch September 8, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

num-procs + admin fails to start
2 participants