Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle session and websocket close cleanly #3769

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3341

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #3769 (89d7c95) into master (4f8ab43) will decrease coverage by 0.00%.
The diff coverage is 65.21%.

@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
- Coverage   83.57%   83.57%   -0.01%     
==========================================
  Files         214      214              
  Lines       31348    31364      +16     
==========================================
+ Hits        26198    26211      +13     
- Misses       5150     5153       +3     
Flag Coverage Δ
ui-tests 33.86% <17.39%> (-0.01%) ⬇️
unitexamples-tests 76.46% <65.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/document.py 66.37% <57.14%> (+1.24%) ⬆️
panel/io/server.py 76.59% <77.77%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 23dc50b into master Aug 22, 2022
@philippjfr philippjfr deleted the websocket_closed_handling branch August 22, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocketClosedError from Streaming Indicators app
1 participant