Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure overflow in MaterialTemplate is not clipped #3492

Merged
merged 1 commit into from
May 6, 2022

Conversation

philippjfr
Copy link
Member

Previously content was simply cut-off in the MaterialTemplate making some dashboards unusable.

@philippjfr philippjfr merged commit 59dcb37 into master May 6, 2022
@philippjfr philippjfr deleted the material_overflow_x branch May 6, 2022 10:14
@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented May 6, 2022

I would argue that its bad design of your dashboard if you need overflow-x: auto. I don't know of any modern applications wanting you to scroll the main content horizontally.

@philippjfr
Copy link
Member Author

Agreed but sometimes you generate fixed size components and then view them on a smaller screen. We shouldn't then clip the output so you can't see it, it's up to the user to correctly implement responsive sizing. None of the other templates have this behavior so this just makes it consistent.

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented May 6, 2022

I've just experienced sometimes with responsive resizing and overflow-x: auto, that you get the scrollbar anyways. It enables you to scroll a very tiny amount. And you have to because a tiny amount of your component is behind the scrollbar. This is also a really bad user experience.

@jbednar
Copy link
Member

jbednar commented May 9, 2022

That sounds like a problem to report separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants