Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added placeholder to on_change for quill.ts #3427

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Added placeholder to on_change for quill.ts #3427

merged 2 commits into from
Apr 19, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 18, 2022

Fixes #3425

Peek.2022-04-18.19-22.mp4

@hoxbro hoxbro changed the title Added placeholder to on change Added placeholder to on_change for quill.ts Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #3427 (26cf0e8) into master (b9c01ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3427   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files         198      198           
  Lines       26999    26999           
=======================================
  Hits        22390    22390           
  Misses       4609     4609           
Impacted Files Coverage Δ
panel/layout/base.py 90.81% <0.00%> (ø)
panel/layout/card.py 96.36% <0.00%> (ø)
panel/layout/flex.py 95.83% <0.00%> (ø)
panel/layout/grid.py 74.92% <0.00%> (ø)
panel/layout/tabs.py 88.28% <0.00%> (ø)
panel/layout/spacer.py 74.07% <0.00%> (ø)
panel/layout/__init__.py 100.00% <0.00%> (ø)
panel/layout/accordion.py 89.79% <0.00%> (ø)
panel/layout/gridstack.py 52.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c01ad...26cf0e8. Read the comment docs.

panel/models/quill.ts Outdated Show resolved Hide resolved
Co-authored-by: Philipp Rudiger <[email protected]>
@philippjfr philippjfr merged commit b616a7e into holoviz:master Apr 19, 2022
@philippjfr
Copy link
Member

Thanks @hoxbro !

@hoxbro hoxbro deleted the fix_quill_placeholder branch April 19, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextEditor placeholder not updating
2 participants