Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure oauth v2.0 endpoint support #3224

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

j-r77
Copy link
Contributor

@j-r77 j-r77 commented Mar 4, 2022

Added a (very simple) additional authentication class that uses Azure AD's v2.0 oauth endpoint. This one uses the standard openid, email, and profile scopes instead of Azure-specific ones.

In particular, I couldn't get the default azuread auth to work with accounts that require MFA.

Azure's own docs suggest using V2.0 for all new applications:
https://docs.microsoft.com/en-us/azure/active-directory/azuread-dev/v1-overview

@philippjfr
Copy link
Member

Love it, thanks for contributing @j-r77!

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #3224 (1a25386) into master (a068ccb) will decrease coverage by 0.02%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3224      +/-   ##
==========================================
- Coverage   83.10%   83.08%   -0.03%     
==========================================
  Files         193      193              
  Lines       25731    25747      +16     
==========================================
+ Hits        21385    21393       +8     
- Misses       4346     4354       +8     
Impacted Files Coverage Δ
panel/auth.py 41.45% <72.22%> (+1.50%) ⬆️
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/tests/pane/test_plotly.py 98.15% <0.00%> (-0.62%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a068ccb...1a25386. Read the comment docs.

@philippjfr philippjfr merged commit 978f291 into holoviz:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants