Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Django resource handling #3116

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix Django resource handling #3116

merged 1 commit into from
Jan 21, 2022

Conversation

philippjfr
Copy link
Member

@sdc50 Before this PR Django wasn't working at all for me since it couldn't load some resources. Did you have similar issues?

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #3116 (998a58a) into master (77882db) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3116      +/-   ##
==========================================
- Coverage   83.10%   83.02%   -0.08%     
==========================================
  Files         192      192              
  Lines       25460    25484      +24     
==========================================
  Hits        21159    21159              
- Misses       4301     4325      +24     
Impacted Files Coverage Δ
panel/io/django.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77882db...998a58a. Read the comment docs.

@philippjfr philippjfr merged commit 9ba9821 into master Jan 21, 2022
@philippjfr philippjfr deleted the django_resource_handling branch January 21, 2022 10:44
@sdc50
Copy link
Contributor

sdc50 commented Jan 21, 2022

Did you have similar issues?

I haven't been able to reproduce this issue. For me using both inline and cdn worked at least sense v0.13.0a28.

Note: I haven't been able to get the bokeh resources server option to work for me because of the URL it tries to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants