Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the orientation parameter of the button group widgets #3083

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jan 9, 2022

This PR simply exposes a Bokeh property not exposed by Panel.

image

Is the CSS of some templates to adapt for this kind of change or is this good to go?

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #3083 (e23584b) into master (e66dea3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3083   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         190      190           
  Lines       25134    25135    +1     
=======================================
+ Hits        20969    20970    +1     
  Misses       4165     4165           
Impacted Files Coverage Δ
panel/widgets/select.py 94.40% <100.00%> (+0.03%) ⬆️
panel/widgets/tables.py 85.53% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66dea3...e23584b. Read the comment docs.

@philippjfr
Copy link
Member

Should be good to go. Thanks @maximlt !

@philippjfr philippjfr merged commit 2beb7ae into master Jan 10, 2022
@philippjfr philippjfr deleted the maximlt_add_orientation_button_group branch January 10, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants