Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fast Vertical Slider CSS #3045

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Fix Fast Vertical Slider CSS #3045

merged 2 commits into from
Dec 29, 2021

Conversation

MarcSkovMadsen
Copy link
Collaborator

Fixes #3003

You can verify via

import panel as pn
import panel.widgets as pnw

horizontal = pnw.FloatSlider(name='Horizontal', value=0, step=0.05, start=0, end=1)
vertical = pnw.FloatSlider(name='Vertical', value=0, step=0.05, start=0, end=1, orientation='vertical')

template = pn.template.FastListTemplate(
    title="FastListTemplate",
    main=[horizontal, vertical]).servable()

image

@philippjfr
Copy link
Member

I'm not a huge fan of how thin the actual slider is. Can we maybe use this opportunity to tweak that a little bit? The original fast slider isn't that thin either.

markup_12264.png

@MarcSkovMadsen
Copy link
Collaborator Author

I've made it larger

image

image

@philippjfr
Copy link
Member

Looks much better to me, thanks for the fix!

@philippjfr philippjfr modified the milestones: v0.12.6, v0.13.0 Dec 29, 2021
@philippjfr philippjfr merged commit 007475d into master Dec 29, 2021
@philippjfr philippjfr deleted the fix-fast-vertical-slider branch December 29, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fast template theme not applied to vertical sliders
2 participants