Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds vega altair style example for the gallery. #3032

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Dec 23, 2021

Addresses #3033

Makes it easier for users to figure out how they can style their Altair and Vega plots

You can try out the notebook and app on binder

Additional Context

Todo:

  • [] Philipp to implement pn.state.theme
  • [] Marc to update notebook to use pn.state.theme.

Promo Video and Gif

VegaAltairStyle.mp4

VegaAltairStyle

@MarcSkovMadsen MarcSkovMadsen changed the title Add vega altair style example for the gallery. Add vega/ altair style example for the gallery. Dec 23, 2021
@MarcSkovMadsen MarcSkovMadsen changed the title Add vega/ altair style example for the gallery. Adds vega altair style example for the gallery. Dec 23, 2021
@philippjfr
Copy link
Member

So I really can't merge any of these PRs because of the large gifs in them. As I suggested on the Home app PR could you send me all the gifs you have as a zip file (via email if necessary) so I can upload them all at once. The only other comment I have is about the get_theme() method and parsing the session_args. I will make a separate PR to expose pn.state.theme explicitly, which should simplify quite a lot of that.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Jan 21, 2022

For now I will include the link to this gif. Please use this link instead @philippjfr

VegaAltairStyle

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #3032 (06b1b48) into master (09bab95) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

❗ Current head 06b1b48 differs from pull request most recent head 33f280b. Consider uploading reports for the commit 33f280b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3032      +/-   ##
==========================================
- Coverage   83.25%   82.99%   -0.27%     
==========================================
  Files         190      193       +3     
  Lines       24971    25481     +510     
==========================================
+ Hits        20789    21147     +358     
- Misses       4182     4334     +152     
Impacted Files Coverage Δ
panel/script.py 0.00% <0.00%> (ø)
panel/models/tabulator.py 95.45% <0.00%> (-3.18%) ⬇️
panel/io/server.py 71.94% <0.00%> (-1.70%) ⬇️
panel/tests/conftest.py 94.85% <0.00%> (-1.05%) ⬇️
panel/auth.py 39.94% <0.00%> (-0.68%) ⬇️
panel/widgets/tables.py 84.97% <0.00%> (-0.58%) ⬇️
panel/command/serve.py 39.26% <0.00%> (-0.31%) ⬇️
panel/pane/vega.py 83.04% <0.00%> (-0.30%) ⬇️
panel/template/base.py 78.43% <0.00%> (-0.28%) ⬇️
panel/tests/test_pipeline.py 98.92% <0.00%> (-0.02%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09bab95...33f280b. Read the comment docs.

@philippjfr
Copy link
Member

@philippjfr philippjfr merged commit 9cecca3 into master Jan 24, 2022
@philippjfr philippjfr deleted the altair-style branch January 24, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants