Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always load imported bokeh extensions #2957

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Nov 29, 2021

Panel.js and other imported extensions should always be loaded.

Fixes regression introduced by #2919

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2957 (a2017e5) into master (336bf0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2957   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files         190      190           
  Lines       24867    24869    +2     
=======================================
+ Hits        20675    20677    +2     
  Misses       4192     4192           
Impacted Files Coverage Δ
panel/io/resources.py 82.72% <100.00%> (ø)
panel/models/layout.py 100.00% <0.00%> (ø)
panel/layout/card.py 92.72% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336bf0e...a2017e5. Read the comment docs.

@philippjfr philippjfr merged commit 640b4c2 into master Nov 29, 2021
@philippjfr philippjfr deleted the bundle_imported_extensions branch November 29, 2021 16:01
philippjfr added a commit that referenced this pull request Dec 7, 2021
@philippjfr philippjfr mentioned this pull request Dec 7, 2021
philippjfr added a commit that referenced this pull request Dec 8, 2021
* Always load imported bokeh extensions (#2957)

* Do not run ace import on initialization (#2959)

* Fix regression rendering HoloViews plotly backend (#2961)

* Fix regression rendering HoloViews plotly backend

* Fix flake

* Improve handling of ReactiveHTML cleanup (#2974)

* Ensure empty Str has same height as non-empty (#2981)

* Ensure Tabulator supports grouping on numeric columns (#2987)

* Fix Tabulator with multi-index and pagination (#2989)

* Fix Tabulator with multi-index and pagination

* Pin Django

* Allow index as column name in table widgets (#2990)

* Allow index as column name in table widgets

* Handle unnamed indexes

* Update CHANGELOG

* Cleanup

* Fix cleanup of children on ReactiveHTML (#2993)

* Ensure TemplateActions component does not have height (#2997)

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant