-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to define custom tornado handler plugins #2752
Conversation
fbbd6e3
to
7f20d2d
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2752 +/- ##
==========================================
- Coverage 82.21% 82.18% -0.03%
==========================================
Files 339 339
Lines 51376 51398 +22
==========================================
+ Hits 42237 42242 +5
- Misses 9139 9156 +17 ☔ View full report in Codecov by Sentry. |
Is it possible to add and remove the handlers dynamically? How does this compare to the REST API already supported? Can a user use Async? How? I would probably prefer that. How to get this to scale? Now you have Panel on web socket where you probable use num-procs and/ or num-threads? What about oauth? Jwt tokens? Swagger api docs? Would it be possible and better to build on FastApi? |
Not with this PR no.
This will let you build generic endpoints to do whatever you want unlike the REST functionality which is much more limited.
Tornado handler HTTP methods like
When using num-procs this endpoint will be duplicated across processes and the requests will be routed just like any other request.
If you've enabled authentication adding the @authenticated decorator will put the endpoint behind OAuth.
If someone decides to reimplement the entire Bokeh server functionality on top of FastAPI I'd be very happy but I'd estimate that would take me 1-2 months. |
Allows defining custom Tornado handler plugins via the
panel serve
CLI.