Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement profiling page for Panel #2645

Merged
merged 14 commits into from
Aug 23, 2021
Merged

Implement profiling page for Panel #2645

merged 14 commits into from
Aug 23, 2021

Conversation

philippjfr
Copy link
Member

Adds an optional /admin endpoint to Panel with profiling output. This will expand to a number of visualization and views to monitor a live Panel server, including seeing currently active sessions, logging output, callbacks, and much more.

Screen Shot 2021-08-18 at 7 59 23 PM

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #2645 (cb96699) into master (5f7e7c0) will decrease coverage by 0.16%.
The diff coverage is 7.40%.

❗ Current head cb96699 differs from pull request most recent head 8145b50. Consider uploading reports for the commit 8145b50 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2645      +/-   ##
==========================================
- Coverage   83.00%   82.84%   -0.17%     
==========================================
  Files         184      185       +1     
  Lines       23354    23404      +50     
==========================================
+ Hits        19386    19389       +3     
- Misses       3968     4015      +47     
Impacted Files Coverage Δ
panel/io/admin.py 0.00% <0.00%> (ø)
panel/io/server.py 58.67% <0.00%> (-0.82%) ⬇️
panel/command/serve.py 14.76% <11.11%> (-0.81%) ⬇️
panel/config.py 58.30% <100.00%> (+0.14%) ⬆️
panel/widgets/indicators.py 92.59% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7e7c0...8145b50. Read the comment docs.

@MarcSkovMadsen
Copy link
Collaborator

Do I see the terminal in action?

@MarcSkovMadsen
Copy link
Collaborator

For inspiration check also scalene out @philippjfr . https://github.com/plasma-umass/scalene

@philippjfr
Copy link
Member Author

@MarcSkovMadsen scalene indeed looks great but I see no way to actually run it from within an existing Python session. The only way I found to invoke it required forking the process and running a code snippet in the forked process.

doc/user_guide/index.rst Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit 85915ef into master Aug 23, 2021
@philippjfr philippjfr deleted the profiling branch August 23, 2021 16:44
@MarcSkovMadsen
Copy link
Collaborator

For me the main take away is also the look and frem which looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants