Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Vega events #2592

Merged
merged 9 commits into from
Nov 30, 2021
Merged

Implement support for Vega events #2592

merged 9 commits into from
Nov 30, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 30, 2021

vega_events

Implements #2365

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #2592 (1304c3d) into master (d6b315f) will decrease coverage by 0.00%.
The diff coverage is 87.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
- Coverage   83.12%   83.12%   -0.01%     
==========================================
  Files         190      190              
  Lines       24900    24953      +53     
==========================================
+ Hits        20697    20741      +44     
- Misses       4203     4212       +9     
Impacted Files Coverage Δ
panel/io/callbacks.py 66.66% <ø> (ø)
panel/models/vega.py 88.00% <75.00%> (-6.12%) ⬇️
panel/pane/vega.py 83.33% <88.88%> (+0.26%) ⬆️
panel/tests/pane/test_base.py 84.31% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b315f...1304c3d. Read the comment docs.

@philippjfr philippjfr modified the milestones: Wishlist, 0.13.0 Aug 12, 2021
@philippjfr philippjfr force-pushed the vega_events branch 2 times, most recently from 0869dde to 4c8bcca Compare November 19, 2021 16:48
@maximlt
Copy link
Member

maximlt commented Nov 19, 2021

Really liking this API! 👍

The description of debounce may need a few more words, or a link to a source explaining what that is, I expect more users not to be acquainted with this sort of concept. And it's pretty important here, not to have an expensive function being called too many times.

Also wondering if this API could in the future be adapted to the other interactive plotting panes, like Bokeh/Matplotlib...

@MarcSkovMadsen
Copy link
Collaborator

+1 for a Commons event API, especially Across plot panes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants