Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for template favicon and metadata handling #1650

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

philippjfr
Copy link
Member

Cleaning up recent PRs adding favicon and metadata handling for the basic templates.

  • Bundles the favicon.ico into the panel.js distribution so it's available as a server resource and will be uploaded to NPM
  • Removes default metadata

To Do:

  • Update docs

@MarcSkovMadsen

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1650 into master will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
- Coverage   85.41%   85.41%   -0.01%     
==========================================
  Files         148      148              
  Lines       16837    16840       +3     
==========================================
+ Hits        14382    14384       +2     
- Misses       2455     2456       +1     
Impacted Files Coverage Δ
panel/template/base.py 72.80% <90.90%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a6d21...dabe5ae. Read the comment docs.

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Oct 19, 2020

Hi @philippjfr

Looks nice. If I can find time I will try to contribute the changes to the docs. But right now I don't if it will be today or within a week. So feel free to do it first.

The changes you have made looks nice.

I can see you have set keywords, description etc. to "". I was in doubt here. The reason why I added something is that have Panel, HoloViz etc. show up in the description, keywords etc. on several sites will make it more known by Google Search Engine as far as I understand. Thus people who use the defaults will be advertising a bit for HoloViz and Panel which is a small price to pay for a great product. But I also understand if you don't want users to "pay that price" maybe without taking an active decision.

@philippjfr
Copy link
Member Author

Yeah, I get your reasoning there. Maybe I should promote more but feel like it'd be a little bit rude to insert that everywhere. Can reconsider that later. For now I'll merge.

@philippjfr philippjfr merged commit 1088ce1 into master Oct 19, 2020
@philippjfr philippjfr deleted the template_cleanup branch October 19, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants