Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs with None default on String params #1622

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Conversation

philippjfr
Copy link
Member

Fixes #1598

@philippjfr
Copy link
Member Author

@mattpap What should the property type be for a property that can be either null or a p.String?

@philippjfr
Copy link
Member Author

Nevermind, found the NullString type.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #1622 into master will increase coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
+ Coverage   85.26%   85.36%   +0.10%     
==========================================
  Files         147      147              
  Lines       16663    16779     +116     
==========================================
+ Hits        14207    14323     +116     
  Misses       2456     2456              
Impacted Files Coverage Δ
panel/widgets/tables.py 89.57% <50.00%> (-0.38%) ⬇️
panel/io/model.py 60.63% <0.00%> (-0.34%) ⬇️
panel/tests/test_server.py 100.00% <0.00%> (ø)
panel/tests/test_template.py 97.91% <0.00%> (+0.32%) ⬆️
panel/viewable.py 70.95% <0.00%> (+0.44%) ⬆️
panel/io/server.py 68.57% <0.00%> (+2.44%) ⬆️
panel/io/state.py 48.87% <0.00%> (+3.37%) ⬆️
panel/io/location.py 85.56% <0.00%> (+4.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7674b86...6ff8152. Read the comment docs.

@philippjfr philippjfr merged commit b07ad9d into master Oct 12, 2020
@philippjfr philippjfr deleted the bk2.3_compat branch October 12, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileDownloadWidget crashes with bokeh 2.3
1 participant