Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DataFrame with no index is editable #1547

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

philippjfr
Copy link
Member

Fixes #1534

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1547 into master will increase coverage by 0.01%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
+ Coverage   85.60%   85.61%   +0.01%     
==========================================
  Files         146      146              
  Lines       16161    16179      +18     
==========================================
+ Hits        13834    13852      +18     
  Misses       2327     2327              
Impacted Files Coverage Δ
panel/widgets/tables.py 89.95% <50.00%> (ø)
panel/models/__init__.py 100.00% <100.00%> (ø)
panel/models/widgets.py 100.00% <100.00%> (ø)
panel/widgets/__init__.py 100.00% <100.00%> (ø)
panel/widgets/select.py 93.24% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4094bc5...7159efa. Read the comment docs.

@philippjfr philippjfr merged commit dd4a3eb into master Aug 24, 2020
@philippjfr philippjfr deleted the df_no_index_edit branch August 24, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_index disables cell editing in dataframe widget
1 participant