Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Panel extensions in Notebook via pn.extension. #1539

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Aug 22, 2020

This PR aims to fix fix #1529 which is about pn.extension, __js_skip__ and __js_require__ not working models not included in Panel.

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #1539 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1539   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         146      146           
  Lines       16076    16076           
=======================================
  Hits        13770    13770           
  Misses       2306     2306           
Impacted Files Coverage Δ
panel/compiler.py 4.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a0729...ce3afc4. Read the comment docs.

@philippjfr
Copy link
Member

Thanks, looks fine to me.

@philippjfr philippjfr merged commit f1c9368 into master Aug 22, 2020
@philippjfr philippjfr deleted the enable-panel-extensions branch August 22, 2020 16:03
philippjfr pushed a commit that referenced this pull request Sep 17, 2020
Co-authored-by: Marc Skov Madsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When trying to use tabulator.info javascript in Notebook I get Javascript error adding output!
2 participants