Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept MethodType as panel.serve parameter #1450

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

nritsche
Copy link
Contributor

Closes #1449

@nritsche
Copy link
Contributor Author

I didn't find an easy way to add a test for this, but it makes my panel application work.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #1450 into master will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
- Coverage   87.89%   87.78%   -0.12%     
==========================================
  Files         135      135              
  Lines       14881    14930      +49     
==========================================
+ Hits        13080    13106      +26     
- Misses       1801     1824      +23     
Impacted Files Coverage Δ
panel/io/server.py 62.63% <100.00%> (ø)
panel/pane/plot.py 63.77% <0.00%> (-11.49%) ⬇️
panel/tests/test_param.py 99.86% <0.00%> (+<0.01%) ⬆️
panel/param.py 91.59% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b258bd0...a7967dd. Read the comment docs.

@philippjfr
Copy link
Member

Thanks! Don't worry about the test for now, I'll also have to set a higher threshold on CodeCov.

@philippjfr philippjfr merged commit 295ce22 into holoviz:master Jun 22, 2020
@nritsche nritsche deleted the rn/servemethods branch June 22, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panel.serve only accepts functions, not methods
2 participants