Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure param callbacks initialized #1439

Merged
merged 2 commits into from
Jun 20, 2020

Conversation

philippjfr
Copy link
Member

Fixes #1327

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #1439 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
+ Coverage   87.90%   87.92%   +0.01%     
==========================================
  Files         135      135              
  Lines       14879    14993     +114     
==========================================
+ Hits        13079    13182     +103     
- Misses       1800     1811      +11     
Impacted Files Coverage Δ
panel/param.py 91.59% <100.00%> (+0.03%) ⬆️
panel/tests/test_param.py 99.86% <100.00%> (+<0.01%) ⬆️
panel/viewable.py 70.17% <0.00%> (+0.39%) ⬆️
panel/io/server.py 71.80% <0.00%> (+9.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c3667...c388b50. Read the comment docs.

@philippjfr philippjfr merged commit 383f306 into master Jun 20, 2020
@philippjfr philippjfr deleted the ensure_param_callbacks_initialized branch June 20, 2020 20:56
philippjfr added a commit that referenced this pull request Jun 21, 2020
* Implement Param.select

* Implement Param.select to ensure JS callbacks are processed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js_on_click does not work for param.Action buttons
1 participant