Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle singular data object in Vega model #1201

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Handle singular data object in Vega model #1201

merged 1 commit into from
Mar 30, 2020

Conversation

philippjfr
Copy link
Member

Fixes bug where Vega data containing a singular data object would not get rendered and raise an error.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f7fe0bb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1201   +/-   ##
=========================================
  Coverage          ?   87.63%           
=========================================
  Files             ?      106           
  Lines             ?    12588           
  Branches          ?        0           
=========================================
  Hits              ?    11031           
  Misses            ?     1557           
  Partials          ?        0           
Impacted Files Coverage Δ
panel/pane/equation.py 80.39% <0.00%> (ø)
panel/tests/pane/test_ace.py 100.00% <0.00%> (ø)
panel/tests/models/test_deckgl.py 100.00% <0.00%> (ø)
panel/callbacks.py 30.43% <0.00%> (ø)
panel/tests/pane/test_holoviews.py 99.46% <0.00%> (ø)
panel/tests/test_docs.py 100.00% <0.00%> (ø)
panel/tests/test_io.py 100.00% <0.00%> (ø)
panel/models/plotly.py 100.00% <0.00%> (ø)
panel/tests/test_cli.py 100.00% <0.00%> (ø)
panel/widgets/base.py 82.92% <0.00%> (ø)
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fe0bb...dcec46b. Read the comment docs.

@philippjfr philippjfr merged commit 13eda85 into master Mar 30, 2020
@philippjfr philippjfr deleted the vega_data_fix branch March 30, 2020 11:29
@philippjfr philippjfr mentioned this pull request Mar 31, 2020
@philippjfr philippjfr added this to the v0.9.4 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant