Add CommManager model to handle notebook comms #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
comm_manager_model
branch
from
5c18477
to
0fa7cbe
Compare
philippjfr
force-pushed
the
comm_manager_model
branch
from
0fa7cbe
to
cb49583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past to make communication work in notebook backends we had to attach callbacks to all bokeh properties we wanted to monitor. This was extremely inefficient because each of these callbacks is ~100 lines of JS code and a large app might have hundreds or even thousands of properties. In this PR we introduce a CommManager model, this model is added to the
Document.rootswhen rendering in a notebook and registers a Document.on_change callback which will dispatch all the protocol messages that bokeh supports to Python. This means that it will behave identically to the server, simplifying codepaths and ensuring that bokeh models stay synced at all times.Benefits: