Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for HoloViews widgets #1163

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Minor fixes for HoloViews widgets #1163

merged 2 commits into from
Mar 19, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 19, 2020

In the last release I made an unfortunate change to DiscreteSlider margins. Additionally this PR hides widgets when there is only a single HoloMap frame.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1163 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   87.81%   87.81%   +<.01%     
==========================================
  Files         105      105              
  Lines       12589    12591       +2     
==========================================
+ Hits        11055    11057       +2     
  Misses       1534     1534
Impacted Files Coverage Δ
panel/pane/holoviews.py 84.63% <100%> (ø) ⬆️
panel/widgets/slider.py 91.18% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b075d...57f8f25. Read the comment docs.

@philippjfr philippjfr merged commit 602e467 into master Mar 19, 2020
sthagen added a commit to sthagen/holoviz-panel that referenced this pull request Mar 19, 2020
Minor fixes for HoloViews widgets (holoviz#1163)
@philippjfr philippjfr deleted the holoviews_fixes branch March 20, 2020 14:49
philippjfr added a commit that referenced this pull request Mar 21, 2020
* Fixed DiscreteSlider margin

* Hide single slider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant