Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure discrete slider respects layout opts #1144

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

philippjfr
Copy link
Member

Fixes #1134

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #1144 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
+ Coverage   87.82%   87.82%   +<.01%     
==========================================
  Files         105      105              
  Lines       12576    12577       +1     
==========================================
+ Hits        11045    11046       +1     
  Misses       1531     1531
Impacted Files Coverage Δ
panel/widgets/slider.py 90.99% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1399f...5d7d795. Read the comment docs.

@philippjfr philippjfr merged commit 7e65881 into master Mar 12, 2020
@philippjfr philippjfr deleted the discrete_slider_fix branch March 20, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiscreteSlider not respecting sizing_mode
1 participant