-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeckGL pane [doc-build] #1019
Conversation
a5b92d3
to
d332bca
Compare
3dd27ea
to
c9d59f7
Compare
@MarcSkovMadsen Thanks so much for getting this started! Getting this to work reliably in Jupyter notebooks and JupyterLab was a huge pain but I've worked out a solution. In JupyterLab (and on the server) we load the individual dependencies while in Jupyter notebooks we load the pydeck jupyter-widget bundle (as you were doing). The former is more efficient overall and really this is kind of hacky but I hope eventually we can have smaller bundles which consistently load the components using npm or get a better mechanism for loading the JS dependencies lazily. For now I'm very happy to have this in 0.8! This should be the last code PR to go in and I should be ready to release tomorrow. |
eb37274
to
f323b2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
==========================================
+ Coverage 85.8% 85.99% +0.19%
==========================================
Files 105 105
Lines 12000 11891 -109
==========================================
- Hits 10296 10226 -70
+ Misses 1704 1665 -39
Continue to review full report at Codecov.
|
Hi @philippjfr I'm so impressed. I could have spent a week on this. Don't know how you know how to do all these things :-) One thing that might be interesting is that I have a more advanced example of using the DeckGL pane. I will create a new pull request to include that. |
Ha, don't put yourself down, you got things 90% there, I just did all the tedium of making things work across across different environments (honestly I wanted to pull my hair out on this) and updating it to the new build infrastructure.
Yes, we need to get the gallery more populated somehow. At some point soon I'll ask people to contribute their examples back to the gallery. A more complex DeckGL example would be hugely appreciated. |
More complex examples should probably be part of examples.pyviz.org, not Panel itself, so that they can have their own separate pinned environment rather than necessarily being updated during every Panel release... |
Supersedes #960
Fixes #957