Add spatialpandas interface and polygon rasterization#4120
Merged
Add spatialpandas interface and polygon rasterization#4120
Conversation
b56dd9d to
fe90b6d
Compare
c6b7f23 to
9a0447f
Compare
Member
Author
|
Handling geometries consistently turned out to be a pretty hard problem taking me most of last week and most of today. Some of the features here:
|
Member
Author
|
Some of the Path plotting code looks pretty terrible now but it should all become much cleaner once I pick up #3986 again. |
Member
Author
|
This is ready to review. |
Member
Author
|
Thanks for the initial review @jlstevens, I've now made sure that only actual geometry interfaces are supported by Path types and reverted the API change on |
jlstevens
reviewed
Dec 18, 2019
philippjfr
commented
Dec 18, 2019
jlstevens
reviewed
Dec 18, 2019
jlstevens
reviewed
Dec 18, 2019
jlstevens
reviewed
Dec 18, 2019
jlstevens
reviewed
Dec 18, 2019
jlstevens
reviewed
Dec 18, 2019
jlstevens
reviewed
Dec 18, 2019
jlstevens
reviewed
Dec 18, 2019
Contributor
|
@philippjfr Other than some comments above (most of which you have addressed already), I am happy to merge this PR now. |
Co-Authored-By: Philipp Rudiger <prudiger@anaconda.com>
a0224a3 to
edc8013
Compare
Contributor
|
Looks good. Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.