Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Widget-based Datashader dashboard #67

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jbednar
Copy link
Contributor

@jbednar jbednar commented Oct 9, 2019

This PR adds a version of the Datashader dashboard based on explicit widget objects rather than defining a class with Parameters from which widgets are synthesized. The functionality should be identical with HoloViews >= 1.12.6 and Panel >= 0.6.4, but it shows the user how to specifically control the type and parameters of every widget while not requiring users to learn about Parameters or about writing their own Parameterized (or any other) custom classes. The two dashboards are meant to be so closely aligned that diff can be used to see the specific differences between the two approaches.

What makes this still be WIP is that when you uncomment #pn.Row(widgets,view) in widgetdashboard.ipynb, the output of that cell doesn't show any plot. It does show a plot if you change the return value of view() to just dataplot * labels (no map tiles), but including the map tiles or their options messes it up. @philippjfr , any ideas?

As it's just a demo, widgetdashboard.ipynb also defaults to nyc_taxi_50k, not nyc_taxi, but once it works it can be changed to share the same default as dashboard.ipynb.

@jsignell
Copy link
Contributor

Adding a height to the base opts seemed to fix the issue.

@philippjfr
Copy link
Contributor

Can it also be fixed with a min_height? That way responsive behaviour isn't entirely disabled.

@jsignell
Copy link
Contributor

Yeah that is a better solution.

@jbednar
Copy link
Contributor Author

jbednar commented Nov 21, 2019

But isn't that just a workaround? Why should including map tiles affect whether there is a plot?

@jsignell
Copy link
Contributor

It doesn't affect whether there is a plot. It affects whether the plot has height=0 presumably because having responsive set to True trumps height, width set on the other plot.

Maybe the question is should responsive=True have a default min_height? I imagine that has been discussed at length in a different repo.

@maximlt
Copy link
Contributor

maximlt commented Jan 9, 2023

@jbednar do you still want this new notebook to be part of the examples? Asking as the PR is pretty old, you might have changed your mind ;)

@jbednar
Copy link
Contributor Author

jbednar commented Jan 19, 2023

Yes, this should be updated and merged, particularly since it's the approach I'd recommend to most users starting out. I sure hope that there are answers to the above issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants