Updates to exoplanet example #463
Conversation
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
exoplanets/exoplanets.ipynb
Outdated
| @@ -35,7 +35,7 @@ | |||
| "import colorcet as cc\n", | |||
| "import hvplot.pandas # noqa\n", | |||
| "\n", | |||
| "hv.extension('bokeh')" | |||
| "hv.extension('bokeh', width=100)" | |||
There was a problem hiding this comment.
| "hv.extension('bokeh', width=100)" | |
| "hv.extension('bokeh')" |
exoplanets/exoplanets.ipynb
Outdated
| "\n", | ||
| "dashboard = pn.template.BootstrapTemplate(title='Exoplanets Explorer')\n", | ||
| "dashboard.main.append('Filter, color, and size the displayed exoplanets using the available widgets, and explore trends in the scatterplot below.')\n", | ||
| "accordion = pn.Accordion(('Background', '''For the past 25+ years, NASA has used ground- and space-based methods to [identify exoplanets](https://exoplanets.nasa.gov/exep/about/missions-instruments) (planets outside of our solar system). In the past ten years in particular, campaigns like Kepler, K2, and TESS have produced an explosion of results. To date, approximately 4,400 exoplanets have been identified, and over 3,000 potential exoplanet candidates have been discovered. \n", |
There was a problem hiding this comment.
There should be a way to better format this, e.g. most of the text is truncated on Github.
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
|
@Azaya89 I pushed some minor changes in 8f1679b. There was an issue with the background card being displayed twice in the app. 
I think the indentation of the multi-line string was occupying too much horizontal space (even more obvious on mobile). This led me to notice break lines in a multi-line string were displayed by default by the Markdown pane (not sure this should be the default, see holoviz/panel#7535). I changed the code to revert that behavior. 
Can you please run the notebook and the app and check everything is okay? 🙏 |
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
|
LGTM!
|
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
Updates to
exoplanetexample to close #189