Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable stream select #77

Open
wants to merge 8 commits into
base: 4.x-dev
Choose a base branch
from
Open

Configurable stream select #77

wants to merge 8 commits into from

Commits on Mar 27, 2023

  1. Update old mentions of newWithRequestContent

    Sander De la Marche committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    cfd09da View commit details
    Browse the repository at this point in the history

  2. Update all old cases of the AbstractRequest constructor 

    Passing a string to any Request is deprecated in 4.x
    Sander De la Marche committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    7d3c067 View commit details
    Browse the repository at this point in the history

  3. Fix the AbstractQuery test

    Sander De la Marche committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    d6496c4 View commit details
    Browse the repository at this point in the history

  4. Make sure the content is always set, even if null

    Sander De la Marche committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    02ff204 View commit details
    Browse the repository at this point in the history

  5. Adjust the content lenght test to factor in the 'test' key of the array

    Sander De la Marche committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    aa4980d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Remove the multi-request stream_select call from Client 

    This method had a bug where, as long as no error was thrown, or timeout
reached, it would report that all sockets inside a collection had responses
even if some of them did not. Checking each socket individually in a loop
is a performance hit, but the only way to report accuratly if a socket
has a response ready.
    Sander De la Marche committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    2129c09 View commit details
    Browse the repository at this point in the history

  2. Add a new property + setter/getter for response polling timeout to re… 

    …quests

This will be passed to the socket as soon as the request is sent. The polling timeout
will then be used by the hasResponse method, which uses stream_select
    Sander De la Marche committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8f256cd View commit details
    Browse the repository at this point in the history

  3. Revert the incomplete test

    Sander De la Marche committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    299c440 View commit details
    Browse the repository at this point in the history