Skip to content

Rename opcodes #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
holiman merged 2 commits into from
Dec 15, 2021
Merged

Rename opcodes #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e8d8a
ops: Rename SHA3 to KECCAK256
axic Nov 29, 2021
7042750
ops: Add mapping for legacy opcode names (SHA3/SUICIDE)
axic Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ops/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const (
SHR = OpCode(0x1C)
SAR = OpCode(0x1D)

SHA3 = OpCode(0x20)
KECCAK256 = OpCode(0x20)
)

// 0x30 range - closure state.
Expand Down Expand Up @@ -257,6 +257,10 @@ func init() {
stringToOp[elem.name] = k
ValidOpcodes = append(ValidOpcodes, k)
}

// Add mapping for legacy opcode names
stringToOp["SHA3"] = KECCAK256
stringToOp["SUICIDE"] = SELFDESTRUCT
}

// StringToOp finds the opcode whose name is stored in `str`.
Expand Down Expand Up @@ -301,7 +305,7 @@ var opCodeInfo = map[OpCode]opInfo{
MULMOD: {"MULMOD", []string{"a", "b", "x"}, []string{"(a * b) mod x"}},

// 0x20 range - crypto.
SHA3: {"SHA3", []string{"offset", "size"}, []string{"keccak256(mem[offset:offset+size])"}},
KECCAK256: {"KECCAK256", []string{"offset", "size"}, []string{"keccak256(mem[offset:offset+size])"}},
// 0x30 range - closure state.
ADDRESS: {"ADDRESS", nil, []string{"address of current context"}},
BALANCE: {"BALANCE", []string{"address"}, []string{"balance of address"}},
Expand Down