Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encrypted transfer #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix encrypted transfer #322

wants to merge 1 commit into from

Conversation

cfoxon
Copy link

@cfoxon cfoxon commented Jul 23, 2021

Encrypted transfer was sending account object to Memo() instead of the account string. This was triggering detection as a key ( len >= 51) and causing a KeyError

Encrypted transfer was sending account object to Memo() instead of the account string. This was triggering detection as a key ( len >= 51) and causing a KeyError
@brianoflondon
Copy link

I can confirm this little fix corrects my issue of sending transfers with encrypted memos.

Would like to see this released asap.

@brianoflondon
Copy link

For anyone else affected by this, in advance of it being folded into Beem properly the following magic works for me which just pulls Beem from @cfoxon 's github instead of the official one.

poetry add git+https://github.com/cfoxon/beem.git@d12631cc131fe9b4846617e21b9d7988360b3433

I'm using Poetry but I suspect this would also work:

pip install git+https://github.com/cfoxon/beem.git@d12631cc131fe9b4846617e21b9d7988360b3433

Poetry uninstalled beem for me, I'm not sure what Pip would do. Package management is not something I'm hugely proficient at.

Copy link
Contributor

@sicarius97 sicarius97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine for me with these changes, can you check this out @holgern ?

@brianoflondon
Copy link

@holgern can this get released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants