Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test throwing in data callback #60

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Test throwing in data callback #60

merged 5 commits into from
Jun 1, 2022

Conversation

kasperisager
Copy link
Contributor

@kasperisager kasperisager commented May 3, 2022

This currently fails on the native side:

node[1793]: ../src/api/callback.cc:141:void node::InternalCallbackScope::Close(): Assertion `(env_->execution_async_id()) == (0)' failed.
[162](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:162)
 1: 0xb09980 node::Abort() [node]
[163](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:163)
 2: 0xb099fe  [node]
[164](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:164)
 3: 0xa42ee0 node::InternalCallbackScope::Close() [node]
[165](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:165)
 4: 0xa432a5 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [node]
[166](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:166)
 5: 0xa43478 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [node]
[167](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:167)
 6: 0xad1efb napi_make_callback [node]
[168](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:168)
 7: 0x7f62cca88f84  [/home/runner/work/libudx/libudx/build/Release/udx.node]
[169](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:169)
 8: 0x7f62cca8611c  [/home/runner/work/libudx/libudx/build/Release/udx.node]
[170](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:170)
 9: 0x7f62cca88830 udx_stream_destroy [/home/runner/work/libudx/libudx/build/Release/udx.node]
[171](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:171)
10: 0x7f62cca8ad92 udx_napi_stream_destroy [/home/runner/work/libudx/libudx/build/Release/udx.node]
[172](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:172)
11: 0xab44dd  [node]
[173](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:173)
12: 0xd53d8e  [node]
[174](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:174)
13: 0xd551af v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
[175](https://github.com/mafintosh/libudx/runs/6270239722?check_suite_focus=true#step:5:175)
14: 0x15f0bf9  [node]

@kasperisager
Copy link
Contributor Author

@mafintosh I've skipped the test for now as Brittle seems to be affected by nodejs/node#38155. Should otherwise be good to go; running the test case outside of Brittle works as expected.

@kasperisager
Copy link
Contributor Author

@mafintosh This is ready for review.

@mafintosh mafintosh merged commit d946ac4 into master Jun 1, 2022
@mafintosh mafintosh deleted the throw-in-data-callback branch June 1, 2022 14:30
jthomas43 pushed a commit to jthomas43/libudx that referenced this pull request Aug 6, 2024
* Test throwing in `data` callback

* Add read buffer reallocation

* Skip test for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants