Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass ebVLRs to the writer. #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bacek
Copy link

@bacek bacek commented Nov 17, 2023

This allows to do full round-trip with parsing actual ebVLRs and then serializing them back.

This allows to do full round-trip with parsing actual ebVLRs and then
serializing them back.
@abellgithub
Copy link
Collaborator

I don't understand the purpose of this. You call these "user_vlr", but they are not user VLRs. The extra byte VLR MUST match the stored data -- I don't understand why a user should want to set this as it can lead to an invalid file.

@bacek
Copy link
Author

bacek commented Nov 17, 2023

I don't understand the purpose of this. You call these "user_vlr", but they are not user VLRs. The extra byte VLR MUST match the stored data -- I don't understand why a user should want to set this as it can lead to an invalid file.

My use case: we create extra dimensions for points and add VLR with correct name and description.

I can add assert that header.ebCount matches user_vlrs

@abellgithub
Copy link
Collaborator

The writer code in lazperf primarily exists to support testing. It's not intended to be used as a complete file writer -- there's no support for VLRs in general in lazperf. If this change is helpful to you, that's great and that's the intent of open source -- modify for your needs, but I'd need some convincing to turn lazperf into a more general LAZ file I/O package, which is what this is taking a step towards. I think I'd want a more general design if we were going to go down that road, rather than just support for user-provided EB VLRs.

@nigels-com
Copy link

nigels-com commented Feb 24, 2024

Lack of general VLR support is a deal-breaker for our use cases. Just FYI.
LASzip is long in the tooth, but gets the job done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants