Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement web-sys/wasm-bindgen support. #6

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kellpossible
Copy link
Collaborator

@kellpossible kellpossible commented Jul 28, 2020

I haven't attempted to maintain compatibility with stdweb in this pull request because I don't have a real project to test it with, and don't have time to make one. Feel free to alter this PR and implement the feature to support both. It seems like the Rust ecosystem is moving over to web-sys anyway, it is now the default for yew. There's also a decent chance that web-sys fixes the issues mentioned in #2 (comment) with the new version of rand on OSX, I'll be testing on this platform soon.

Tested on Linux and Window (Edge).

@hobofan
Copy link
Owner

hobofan commented Jul 28, 2020

Awesome! 👏 I do want to keep stdweb compatibility for now, as I also have a project where I use it and probably won't fully convert for some time. Should hopefully get around to adjusting it this weekend.

@kellpossible
Copy link
Collaborator Author

I thought that might be the case, well we've got both uses covered between us which is good!

@kellpossible
Copy link
Collaborator Author

Just a heads up, it looks like yew is planning to drop support for stdweb soon: yewstack/yew#1569

@hobofan
Copy link
Owner

hobofan commented Sep 22, 2020

Yay! I've already heard the chatter about it on the Yew discord and have since started to accelerate my refactor efforts to get rid of stdweb. Will merge the PR, once I'm done with my relevant private project!

Sorry for not getting around to this PR when I said I would, but life just keeps getting in the way 😬

@kellpossible
Copy link
Collaborator Author

No worries 🙂 take your time, I'm working from a fork which has a some more controversial changes which may never get merged upstream, so there's no hurry with this one on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants