-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement web-sys/wasm-bindgen support. #6
base: master
Are you sure you want to change the base?
Conversation
Awesome! 👏 I do want to keep |
I thought that might be the case, well we've got both uses covered between us which is good! |
Just a heads up, it looks like |
Yay! I've already heard the chatter about it on the Yew discord and have since started to accelerate my refactor efforts to get rid of stdweb. Will merge the PR, once I'm done with my relevant private project! Sorry for not getting around to this PR when I said I would, but life just keeps getting in the way 😬 |
No worries 🙂 take your time, I'm working from a fork which has a some more controversial changes which may never get merged upstream, so there's no hurry with this one on my part. |
web-sys
/wasm-bindgen
Make frontend compatible with web_sys and make it the default #4 .I haven't attempted to maintain compatibility with
stdweb
in this pull request because I don't have a real project to test it with, and don't have time to make one. Feel free to alter this PR and implement the feature to support both. It seems like the Rust ecosystem is moving over toweb-sys
anyway, it is now the default foryew
. There's also a decent chance thatweb-sys
fixes the issues mentioned in #2 (comment) with the new version ofrand
on OSX, I'll be testing on this platform soon.Tested on Linux and Window (Edge).