-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring course #178
Merged
jggoebel
merged 10 commits into
hobbyfarm:master
from
svalabs:314-02-refactoring-course
Oct 16, 2023
Merged
Refactoring course #178
jggoebel
merged 10 commits into
hobbyfarm:master
from
svalabs:314-02-refactoring-course
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding course-wizard component. *Transfer the previous functionalities from Course to course-wizard for Adding, editing and deleting courses
…to user to either delele or create a new course
…from step Scenario to dynamic scenario to finalize
…ing the rule of access for scenario and dynamic scenario in CourseWizard component
jggoebel
reviewed
Oct 13, 2023
src/app/data/scenario.service.ts
Outdated
@@ -139,6 +139,7 @@ export class ScenarioService { | |||
|
|||
return this.http.post(environment.server + '/a/scenario/new', params).pipe( | |||
catchError((e: HttpErrorResponse) => { | |||
console.log("I am the error, I am showing you my face") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a Course Wizard for Course.
Transfer functionality from Course component to Course wizard component.
The functionalities are the following:
Adding New Course
Editing Course
Deleting Course