monolith is not embedding SVG files correctly #289

[kamtschatka]

passing in the URL of the page to have the proper URL for resolving relative paths

[kamtschatka]

Did some testing

Running this:

cat asdf.html | monolith - -Ij -t 5 -b https://musictheory.pugetsound.edu/ -o svg.html
cat asdf.html | monolith - -Ij -t 5 -b https://musictheory.pugetsound.edu/mt21c -o svg.html

Results in this:

https://musictheory.pugetsound.edu/images/unit2/Roman-numerals-dia-chords-all-minor.svg (404 Not Found)
https://musictheory.pugetsound.edu/images/unit2/DiatonicTriadsNatMinorAudio.mp3 (404 Not Found)
https://musictheory.pugetsound.edu/images/unit2/DiatonicTriadsHarmMinorAudio.mp3 (404 Not Found)
https://musictheory.pugetsound.edu/images/unit2/DiatonicTriadsMelMinorAudio.mp3 (404 Not Found)
https://musictheory.pugetsound.edu/images/unit2/Roman-numerals-most-common-in-minor.svg (404 Not Found)

Running:

cat asdf.html | monolith - -Ij -t 5 -b https://musictheory.pugetsound.edu/mt21c/ -o svg.html
cat asdf.html | monolith - -Ij -t 5 -b https://musictheory.pugetsound.edu/mt21c/DiatonicChordsInMinor.html -o svg.html 

Results in this:

https://musictheory.pugetsound.edu/mt21c/images/unit2/Roman-numerals-dia-chords-all-minor.svg
https://musictheory.pugetsound.edu/mt21c/images/unit2/DiatonicTriadsNatMinorAudio.mp3
https://musictheory.pugetsound.edu/mt21c/images/unit2/DiatonicTriadsHarmMinorAudio.mp3
https://musictheory.pugetsound.edu/mt21c/images/unit2/DiatonicTriadsMelMinorAudio.mp3
https://musictheory.pugetsound.edu/mt21c/images/unit2/Roman-numerals-most-common-in-minor.svg

So monolith seems to be running some automatic base path detection anyways, if you put in the URL of the page.

[MohamedBassem]

Good catch!