Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ollama tagging #162

Merged
merged 4 commits into from
May 18, 2024

Conversation

kamtschatka
Copy link
Contributor

Move the instructions to create tags and provide them as JSON to the end of the prompt to improve the result.

Copy link

vercel bot commented May 17, 2024

@kamtschatka is attempting to deploy a commit to the Mohamed Bassem's projects Team on Vercel.

A member of the Team first needs to authorize it.

@@ -97,12 +97,17 @@ with the key "tags" and the value is list of tags. Don't wrap the response in a

const TEXT_PROMPT_BASE = `
Copy link

@redoracle redoracle May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish was possible to customise TEXT_PROMPT_BASE and TEXT_PROMPT_INSTRUCTIONS directly within the settings menu in all apps.

Great idea a nice job so far! I look forward for the ollama integrated version!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to give the people the freedom to add whatever instructions they want to be honest because it limits my ability to change or improve the prompt in the future. What I can do instead, is maybe allow the users to add some extra instructions at the end.

Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally and seems to be working well! Thanks! Let's merge after that one small comment is fixed.

apps/workers/openaiWorker.ts Outdated Show resolved Hide resolved
@kamtschatka
Copy link
Contributor Author

yeah I tried it with my exported bookmarks(~250) from chrome and only had a few untagged bookmarks, but that was due to no content being retrieved. Definitely better than before

@MohamedBassem MohamedBassem merged commit fdc27d3 into hoarder-app:main May 18, 2024
3 of 5 checks passed
@MohamedBassem
Copy link
Collaborator

yeah I tried it with my exported bookmarks(~250) from chrome and only had a few untagged bookmarks

That's amazing. Merged!

@kamtschatka kamtschatka deleted the improve-ollama-tagging branch May 19, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants