Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] National Team Prospects View & Lineup Bug Fix #1832

Open
Achill-3s opened this issue Mar 18, 2023 · 9 comments
Open

[FEATURE] National Team Prospects View & Lineup Bug Fix #1832

Achill-3s opened this issue Mar 18, 2023 · 9 comments
Labels
reso: CHPP Resolution requires CHPP changes scope: NT Concerne national teams
Milestone

Comments

@Achill-3s
Copy link

Is your feature request related to a problem? Please describe.
As a National Coach, I can only see my selected lineup.
It would be much more useful to be able to see the 150 NT Prospects which are selected into a different tab.
image

Describe the solution you'd like
Create new Tab called 'NT Prospects'.
Display all selected Prospects in a similar way to the Tab 'Squad'
Allow button to move Prospects from the 'NT Prospects' Tab to the 'Squad' Tab.
This should also automatically update the Prospects in Hattrick side.

Additional context
Also there is a bug where when you setup the lineup of the National Team and you try to upload your orders, it gives the error that you cannot do so, because it is not your own team.
It shouldn't gives this error for the National Coach.
image

@wsbrenk wsbrenk self-assigned this Mar 18, 2023
@wsbrenk wsbrenk added this to the 7.0 milestone Mar 18, 2023
@wsbrenk
Copy link
Collaborator

wsbrenk commented Mar 18, 2023

i will try to fix the match order bug first.

Concerning NT Prospects, i don't know if the required information can be accessed by the chpp api.

wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Mar 18, 2023
wsbrenk added a commit that referenced this issue Mar 18, 2023
* #1834 fix loading of attitude in match lineup orders

* #1832 nt team match order download with same file version as normal teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@Achill-3s
Copy link
Author

Let me know if there is any way i can help you out, such as testing etc.

Also the prospects api, only the Hattrick developers will logically know.
So i assume you have a way to contact them for the above or do you want me to try to reach out for them instead?

@wsbrenk
Copy link
Collaborator

wsbrenk commented Mar 18, 2023

this is from CHPP request list:

Important

  • add Prospects and Staff lists for NT teams

@wsbrenk
Copy link
Collaborator

wsbrenk commented Mar 18, 2023

@Achill-3s newest beta changed the nt match order access. I can't test it by myself.

@Achill-3s
Copy link
Author

Achill-3s commented Mar 18, 2023

@wsbrenk Still pulls an error, a different one this time.
Seems like you have part of code trying to verify if the NT Teamid has me as the Owner ID, instead of the NT Coach.

My User ID is 13724902 and the NT TeamId is 3140 when you testing the code, since you most probably matching wrong fields there for your validation, as it's probably different to normal Teams where there is actual Owner and not a Coach ID.

HO Beta Version - HO-7.0.478.1-portable-win-BETA-JRE
JRE Version - 17.0.3

java.lang.RuntimeException: CHPP Error - 59 - (59) Additional Info: The supplied teamId does not refer to a senior or youth team managed by the requesting user
at core.net.MyConnector.uploadMatchOrder(MyConnector.java:359)
at core.net.OnlineWorker.uploadMatchOrder(OnlineWorker.java:716)
at module.lineup.lineup.MatchAndLineupSelectionPanel.uploadLineupToHT(MatchAndLineupSelectionPanel.java:369)
at module.lineup.lineup.MatchAndLineupSelectionPanel.lambda$addListeners$1(MatchAndLineupSelectionPanel.java:194)
at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2313)
at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
at java.desktop/java.awt.Component.processMouseEvent(Component.java:6626)
at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3389)
at java.desktop/java.awt.Component.processEvent(Component.java:6391)
at java.desktop/java.awt.Container.processEvent(Container.java:2266)
at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5001)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833)
at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4948)
at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4575)
at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4516)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2310)
at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:722)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:716)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:746)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:744)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:743)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

image

image

HO-1679176985.log

wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Mar 19, 2023
wsbrenk added a commit that referenced this issue Mar 19, 2023
…al teams (#1836)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Mar 19, 2023
@Achill-3s
Copy link
Author

Achill-3s commented Mar 20, 2023

Hello [wsbrenk],
NT Match Order Issue still persists.

Attaching the file you have requested.
Also check your HT-Mail ingame for info for it.

image
cynt.zip

@wsbrenk
Copy link
Collaborator

wsbrenk commented Apr 5, 2023

It looks like the match orders for NT Teams is not supported by CHPP. Download did not work today.

@Achill-3s
Copy link
Author

Achill-3s commented Apr 5, 2023

Please find updated file.
cynt2.zip

@wsbrenk wsbrenk added reso: CHPP Resolution requires CHPP changes and removed status: needs test might be fixed, needs test before closing labels Apr 6, 2023
@wsbrenk wsbrenk modified the milestones: 7.0, 8.0 Apr 6, 2023
@wsbrenk
Copy link
Collaborator

wsbrenk commented Apr 16, 2023

download of nt prospects is on the chpp feature request list (not available yet in ht).

what could be done in next HO version:
add a feature to import tracker hrfs to an extra prospect panel

@wsbrenk wsbrenk added the scope: NT Concerne national teams label Jul 12, 2023
tychobrailleur pushed a commit to tychobrailleur/HO-t that referenced this issue Sep 16, 2023
* ho-dev#1834 fix loading of attitude in match lineup orders

* ho-dev#1832 nt team match order download with same file version as normal teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
tychobrailleur pushed a commit to tychobrailleur/HO-t that referenced this issue Sep 16, 2023
…s normal teams (ho-dev#1836)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk wsbrenk modified the milestones: 8.0, 9.0 Dec 10, 2023
@wsbrenk wsbrenk removed their assignment Sep 8, 2024
@wsbrenk wsbrenk modified the milestones: 9.0, 10.0 Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reso: CHPP Resolution requires CHPP changes scope: NT Concerne national teams
Projects
None yet
Development

No branches or pull requests

2 participants