Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Market Value is empty #1594

Open
masterpatje opened this issue Jul 22, 2022 · 11 comments
Open

[FEATURE] Market Value is empty #1594

masterpatje opened this issue Jul 22, 2022 · 11 comments
Labels
reso: CHPP Resolution requires CHPP changes
Milestone

Comments

@masterpatje
Copy link

Describe the bug
In previous version of hattrick (before H.O. 3.0 I think) there was a market value. Is it possible to re-establish this feature in HO 7.0?

Screenshots
image

@wsbrenk wsbrenk added this to the 7.0 milestone Jul 23, 2022
@wsbrenk
Copy link
Collaborator

wsbrenk commented Jul 23, 2022

@masterpatje i don't know if that was a duplicate of the tsi column. i would remove it.

@masterpatje
Copy link
Author

I know that the indicated column would represent the market value in M€. It would hold an indication of the value that could be seen in 'transfer comparison'. I don't know if it was exact that value as shown in hattrick or based on an algorithm.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Dec 29, 2022

                //TSI löste Marktwert ab!
                ele = (Element) root.getElementsByTagName("TSI").item(0);
                hash.put("MarketValue", (XMLManager.getFirstChildNodeValue(ele)));

this change is from before 2018. in transfer module similar changes are found.

i don't have an idea what to put into this column.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Dec 29, 2022

maybe we could implement something compareble to hattricks transfer search

@wsbrenk wsbrenk modified the milestones: 7.0, 8.0 Dec 29, 2022
@masterpatje
Copy link
Author

That would be a good idea. This is a field that can be of good use. I know that I used it also in earlier versions to do sorting on players that are highly valuable on the market. It can be field used for determining which players are best to be trained or to trade them more optimal.

@masterpatje
Copy link
Author

Hattrick implemented a change. On each increase or decrease of skill a new market value is calculated. It is actually an indication of how much worth a player is on the current transfer market.

Is this information available in a form for you as developers when downloading the hrf files?

As a rule. The market value field can then be filled with the last known value in M€.

@tychobrailleur
Copy link
Collaborator

tychobrailleur commented Jan 16, 2024

Is this information available in a form for you as developers when downloading the hrf files?

There doesn't seem to be any info on market value in the player details API. There isn't any recent change in the Changelog indicating changes in that area either.

We can keep an eye out and see if this change propagates to CHPP in the coming weeks. Do you have a link to the announcement?

@masterpatje
Copy link
Author

masterpatje commented Jan 17, 2024 via email

@wsbrenk
Copy link
Collaborator

wsbrenk commented Feb 18, 2024

image

These values are not part of any chpp-api file until today

@wsbrenk wsbrenk added the reso: CHPP Resolution requires CHPP changes label Feb 18, 2024
@wsbrenk wsbrenk modified the milestones: 8.0, 9.0 Feb 18, 2024
@wsbrenk
Copy link
Collaborator

wsbrenk commented Feb 18, 2024

there is already a change request on the chpp development list: https://www83.hattrick.org/Forum/Read.aspx?t=17373595&n=2&v=0

@masterpatje
Copy link
Author

Combine with #1910. Same request.

@wsbrenk wsbrenk modified the milestones: 9.0, 10.0 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reso: CHPP Resolution requires CHPP changes
Projects
None yet
Development

No branches or pull requests

3 participants