Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update eslint-plugin-react to latest #230

Conversation

elitenoire
Copy link
Contributor

This will fix the issue className missing in prop validation from the eslint rule react/prop-types as given by the devs of the plugin

@ickynavigator ickynavigator merged commit 6f9895a into hngprojects:main Jul 18, 2024
2 checks passed
@elitenoire
Copy link
Contributor Author

For Future Viewers,

In addition to the fix applied (updating to the latest eslint-plugin-react),

Refactor all React.[] namespaced imports to named imports

- import * as React from 'react';
+ import { forwardRef, type ComponentProps, type ReactNode } from 'react';
- const Breadcrumb = React.forwardRef<
...

+ const Breadcrumb = forwardRef<
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants