This repository was archived by the owner on May 12, 2026. It is now read-only.
refactor: remove unused modules and repair affected specs - #2
Merged
Merged
Conversation
…llers - Deleted TimezonesController, TimezonesService, and related files. - Removed WaitlistController, WaitlistService, and associated DTOs and entities. - Cleaned up user entity by removing unused relationships and properties. - Removed test files related to timezones and waitlist. - Deleted unused image files from uploads directory. Co-authored-by: Copilot <copilot@github.com>
The cleanup PR removed the timezones, waitlist, organisations, notification-settings, and invite modules but left three spec files referencing deleted modules and methods, so jest failed to compile and CI was red. - auth.service.spec.ts: drop OrganisationsService import, provider, and mock; align createNewUser and loginUser expected responses with the shape the service now returns; rename the enable2FA error test to reflect that the service no longer wraps repository errors. - notifications.service.spec.ts: drop NotificationSettings entity and NotificationSettingsService imports/providers; remove describe blocks for markNotificationAsRead, markAllNotificationsAsReadForUser, and createNotification, since those methods no longer exist on the service after cleanup. - profile.service.spec.ts: replace the import from the deleted invite/mocks/mockUser with the local profile/mocks/mockUser. - profile/mocks/mockUser.ts: add a mockUser export with a populated profile so the upload-profile-picture tests still have a fixture. No deleted module is restored. Lint, build, and full jest suite are green: 11 suites, 104 tests pass.
Contributor
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a significant cleanup of the codebase by removing unused modules, services, and controllers, including seeding logic, billing plans, and blog categories. However, several issues were identified: the SuperAdminGuard was effectively disabled, the NotificationsModule is redundantly imported, the markAllNotificationsAsRead endpoint is now non-functional, and the seeding service file was commented out rather than deleted.
Homoakin619
approved these changes
May 5, 2026
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Removes the modules and supporting files the platform no longer needs (timezones, waitlist, organisations, notification-settings, invite, languages, translation, plus related guards, mappers, mocks, and seed data) and repairs the three test suites that referenced the deleted code so CI is green.
This is a parallel submission to #1 — same cleanup commit, with an additional commit on top that fixes the tests so the
Lint, Build and Testworkflow passes.Related Issue
Supersedes #1 (same scope, with passing CI).
Type of Change
How Has This Been Tested?
Three consecutive clean runs of the same commands the CI workflow runs (
npm run lint->npm run build->npm test). All green every time.Reproduce locally
npm install npm run lint npm run build npm testWhat changed in the test files
src/modules/auth/tests/auth.service.spec.ts— drop the deletedOrganisationsServiceimport, provider, and mock; align thecreateNewUserandloginUserexpected payloads with the response shape the service actually returns now (noorganisationsarray, nois_superadmin); rename theenable2FAerror test to reflect that the service no longer wraps repository errors.src/modules/notifications/tests/notifications.service.spec.ts— drop the deletedNotificationSettingsentity andNotificationSettingsServiceimports/providers; remove themarkNotificationAsRead,markAllNotificationsAsReadForUser, andcreateNotificationdescribe blocks because those methods no longer exist onNotificationsServiceafter the cleanup.src/modules/profile/tests/profile.service.spec.ts— replace the import from the deletedinvite/mocks/mockUserwith the localprofile/mocks/mockUser.src/modules/profile/mocks/mockUser.ts— add amockUserexport (with a populatedprofile) alongside the existingmockUserWithProfile, so the upload-profile-picture tests have a usable fixture without depending on the deletedinvitemodule.No deleted module was restored.
Test Evidence
Screenshots (if applicable)
N/A — refactor only, no UI or user-facing surface area changed.
Documentation Screenshots (if applicable)
N/A.
Checklist
Additional Notes
The cleanup commit (4619ead) is identical to the one in #1; the only added work is the spec-repair commit on top. If reviewers prefer to land the cleanup via #1 instead, the test-repair commit can be cherry-picked onto that branch.