Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALS-4893] Pin versions of both jenkins and plugins #75

Merged
merged 14 commits into from
Sep 12, 2023

Conversation

JamesPeck
Copy link
Contributor

@JamesPeck JamesPeck commented Aug 31, 2023

Also includes minor fixes for Google Analytics jobs and CSP

@gitguardian
Copy link

gitguardian bot commented Aug 31, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7937095 Generic High Entropy Secret ef78623 initial-configuration/jenkins/jenkins-docker/plugins.txt View secret
7937095 Generic High Entropy Secret 9c73c39 initial-configuration/jenkins/jenkins-docker/plugins.txt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

JamesPeck and others added 3 commits August 31, 2023 14:52
move from &quot and &amp to the character literals
Revert && for &&
@Luke-Sikina Luke-Sikina added the enhancement New feature or request label Sep 11, 2023
@JamesPeck JamesPeck merged commit 3a40f1b into release/0002 Sep 12, 2023
1 check passed
@JamesPeck JamesPeck deleted the pin-versions branch September 12, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants