MTDSA-25842 - copy shared code across #181
Conversation
|
|
||
| @Singleton | ||
| class Def1_AmendBenefitValidator(nino: String, taxYear: String, benefitId: String, body: JsValue) extends Validator[AmendBenefitRequestData] { | ||
|
|
||
| private val minYear = 1900 | ||
| private val maxYear = 2100 | ||
|
|
||
| @nowarn("cat=lint-byname-implicit") |
There was a problem hiding this comment.
I assume we are removing this no-warn because this has since been patched? Aiven-Open/guardian-for-apache-kafka#86
| @@ -31,6 +31,7 @@ lazy val microservice = Project(appName, file(".")) | |||
| update / evictionWarningOptions := EvictionWarningOptions.default.withWarnScalaVersionEviction(false), | |||
| scalaVersion := "2.13.12", | |||
| scalacOptions ++= List( | |||
| "-Xlint:-byname-implicit", | |||
| "-Xfatal-warnings", | |||
There was a problem hiding this comment.
Ah this makes sense to add that in! Cool :)
There was a problem hiding this comment.
Yes. There were cases in shared that didn't have the "@nowarn" annotation. So had to put this in here and remove the one on the validator.
| @@ -0,0 +1,152 @@ | |||
| #! python3 | |||
|
|
|||
There was a problem hiding this comment.
I wasn't aware that we've already made a script for this. Should this be in another PR for clarity? Or because it's in BSAS, it should be part of this shared code moving? Not really sure but thought that this is interesting
There was a problem hiding this comment.
Yes. This is part of the shared code that needs to be copied from BSAS.
No description provided.