Adding the conditional reveal from GOV.UK Elements... #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 6, 2018 14:09
…as the component library wasn’t being cleaned out when just running the ‘component-library’ task on its own. These are now ran in sequence.
…ent() function from GOV.UK Elements so you can use the conditional reveal on radio buttons.
hmrc-web-operations
pushed a commit
that referenced
this pull request
Jun 7, 2018
generated from commit 7c17829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add the conditional reveal functionality on the likes of the radio buttons from GOV.UK Elements as the ability to use this pattern is missing in Assets Frontend.
Problem
The conditional reveal functionality does not work as its missing CSS rules and a initialisation on a JS function from GOV.UK Elements.
Solution
In the JavaScript call a new instance of the function constructor GOVUK.ShowHideContent() and initialise it. Then add the CSS rules that hide the content when JavaScript is active(we have these classes in Modernizr but these are different from the ones used in GOV.UK Elements).