Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the component library template folder from git #964

Merged
merged 4 commits into from
Jun 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ target/
/design-pattern-library/
/design-system/
/component-library/
/component-library-template/
!gulpfile.js/util/component-library/
vrt-output/
backstop.json
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed the `sign-out` link on the *Help users when we sign them out...* page examples [953](https://github.com/hmrc/assets-frontend/pull/953)
- Fixed a couple of typos on the _opens in a new window or tab_ page [954](https://github.com/hmrc/assets-frontend/pull/954)
- Fixed table layout issue on messages pattern full width [959](https://github.com/hmrc/assets-frontend/pull/959)
- Removed unwanted folder called component library template from git [964](https://github.com/hmrc/assets-frontend/pull/964)

### Changed
- Moved the header pattern to patterns and updated documentation [944](https://github.com/hmrc/assets-frontend/pull/944)
Expand All @@ -26,7 +27,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- New pattern for asking users for their consent to meet GDPR and DPA standards [#962](https://github.com/hmrc/assets-frontend/pull/962)
- New patterns for help users when we cannot confirm who they are and tell user we have confirmed who they are [#942](https://github.com/hmrc/assets-frontend/pull/942)
- New patterns for users to add information with multiple parts to a list [#963](https://github.com/hmrc/assets-frontend/pull/963)

## [3.2.4] and [4.2.4] - 2018-04-12
### Fixed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@

A definition list based layout for use in confirmation pages.

Based upon the GOV.UK service manual [design pattern](https://www.gov.uk/service-manual/design/check-your-answers-pages).

{{ example("check-your-answers.html") }}
Based upon the GOV.UK service manual [design pattern](https://www.gov.uk/service-manual/design/check-your-answers-pages).
19 changes: 0 additions & 19 deletions assets/components/check-your-answers/_check-your-answers.scss
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,6 @@
// using margin instead of padding because of easier absolutely positioning of .change
}

.cya-question--light {
font-weight: normal;
}

.cya-delete {
text-align: right;
display: block;
margin: 0;

@include media(desktop) {
display: table-cell;
padding-right: 0;
+ .cya-change {
width: 6em;
}
}

}

> *:first-child .cya-question {
margin-top: 0;
}
Expand Down
49 changes: 0 additions & 49 deletions assets/patterns/add-to-a-list/README.md

This file was deleted.

Binary file not shown.
42 changes: 0 additions & 42 deletions assets/patterns/add-to-a-list/add-to-list-change.html

This file was deleted.

18 changes: 0 additions & 18 deletions assets/patterns/add-to-a-list/add-to-list-delete-director.html

This file was deleted.

Binary file not shown.
Binary file removed assets/patterns/add-to-a-list/add-to-list.gif
Binary file not shown.
42 changes: 0 additions & 42 deletions assets/patterns/add-to-a-list/add-to-list.html

This file was deleted.

1 change: 0 additions & 1 deletion component-library-template
Submodule component-library-template deleted from e359f0
117 changes: 0 additions & 117 deletions gulpfile.js/tests/copyImageAssets.test.js

This file was deleted.

This file was deleted.

Empty file.
Binary file not shown.

This file was deleted.

20 changes: 10 additions & 10 deletions gulpfile.js/tests/writeFiles.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ test('writeFiles - writes a file to a given destination', function (t) {
var config = getConfig(destination)

writeFiles(config, files)
.then(function (returnValue) {
.then(function (message) {
var outputFile = fs.readFileSync(path.join(destination, filePath))

t.ok(
Expand All @@ -54,10 +54,10 @@ test('writeFiles - writes a file to a given destination', function (t) {
'with the file contents as the HTML file\'s contents'
)

t.deepEqual(
returnValue,
files,
'Returns the original files array'
t.equal(
message,
'Design pattern library created',
'and returns a sucess message'
)
})
.then(function () {
Expand Down Expand Up @@ -126,7 +126,7 @@ test('writeFiles - takes an optional base directory', function (t) {
del.sync([destination])

writeFiles(config, files)
.then((returnValue) => {
.then((message) => {
t.deepEqual(
fs.readdirSync(destination),
['category', 'index.html'],
Expand All @@ -139,10 +139,10 @@ test('writeFiles - takes an optional base directory', function (t) {
`with the correct directory structure`
)

t.deepEqual(
returnValue,
files,
'Returns the original files array'
t.equal(
message,
'Design pattern library created',
'and returns a sucess message'
)
})
.then(() => {
Expand Down
Loading