Running the patterns tests alongside components tests. #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmrc-web-operations
pushed a commit
that referenced
this pull request
May 3, 2018
generated from commit 36586e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Without this commit tests in the
patternsdirectory aren't being run, this currently only affectstimeout-dialog.test.js.Solution
Add the the
patternsdirectory alongsidecomponentsin the config, fix the path in thetimeout-dialog.test.jsTesting approach
To prove this works I've changed the expectation of a test and watched it fail, then corrected it and watched it pass. This pass/fail was achieved via
npm start