Allow tracking with universal analytics #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 14, 2018 12:40
|
Branch looks ok running locally (999-SNAPSHOT) - seeing stageprompt configured GA once again .. |
|
Great! Thanks for that @markhunter27. I'll get someone to merge it. |
hmrc-web-operations
pushed a commit
that referenced
this pull request
Feb 16, 2018
generated from commit 2e40d2a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #913
Problem
The version of stageprompt in
govuk_frontend_toolkitdoesn't allow for universal analytics.Solution
Revert back to our fork of the old stageprompt repo which has the fix in.
This should be considered a temporary fix until alphagov/govuk_frontend_toolkit#421 gets merged.
Example Screenshot