Remove account menu from the navigation #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gavinwye the design system only generates pages for directories with a file named exactly it would be better to rename the README to something like |
|
@rpowis I tried renaming the file to |
|
Ah! ok, i'll investigate as that shouldn't be happening. |
|
@rpowis I've renamed the README file now and it's not displaying so this should be good to merge now. |
csabascript
approved these changes
Nov 30, 2017
hmrc-web-operations
pushed a commit
that referenced
this pull request
Nov 30, 2017
generated from commit 59ac270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The account menu is in the design system without any documentation to tell people how to use i
Solution
This PR removes it from the design system so that people don't start using it in the wrong way